remove unnecessary withCacheAsync
This commit is contained in:
@@ -1,10 +1,5 @@
|
||||
import { expect, test, vi } from "vitest";
|
||||
import {
|
||||
type Cache,
|
||||
memoize,
|
||||
withCache,
|
||||
withCacheAsync,
|
||||
} from "#/engine/lib/cache.ts";
|
||||
import { type Cache, memoize, withCache } from "#/engine/lib/cache.ts";
|
||||
|
||||
test("withCache", () => {
|
||||
const cache: Cache<number> = new Map();
|
||||
@@ -28,18 +23,18 @@ test("withCache", () => {
|
||||
expect(fn).toHaveBeenCalledTimes(3);
|
||||
});
|
||||
|
||||
test("withCacheAsync", async () => {
|
||||
test("async withCache", async () => {
|
||||
const cache: Cache<Promise<number>> = new Map();
|
||||
const fn = vi.fn(async (value: string): Promise<number> => {
|
||||
return parseFloat(value);
|
||||
});
|
||||
const callback = withCacheAsync(fn, cache);
|
||||
const callback = withCache(fn, cache);
|
||||
|
||||
const one = "1";
|
||||
const res = callback("one", one);
|
||||
const _ = callback("one", one);
|
||||
const res = await callback("one", one);
|
||||
const _ = await callback("one", one);
|
||||
|
||||
expect(await res).toBe(1);
|
||||
expect(res).toBe(1);
|
||||
expect(fn).toHaveBeenCalledTimes(1);
|
||||
|
||||
expect(await callback("two", "2")).toBe(2);
|
||||
@@ -78,10 +73,10 @@ test("async memoize", async () => {
|
||||
const [callback, cache] = memoize(fn);
|
||||
|
||||
const one = "1";
|
||||
const res = callback(one);
|
||||
const _ = callback(one);
|
||||
const res = await callback(one);
|
||||
const _ = await callback(one);
|
||||
|
||||
expect(await res).toBe(1);
|
||||
expect(res).toBe(1);
|
||||
expect(fn).toHaveBeenCalledTimes(1);
|
||||
|
||||
expect(await callback("2.0")).toBe(2);
|
||||
|
||||
@@ -22,25 +22,6 @@ export function withCache<T, U extends (...args: Parameters<U>) => T>(
|
||||
};
|
||||
}
|
||||
|
||||
export function withCacheAsync<
|
||||
T,
|
||||
U extends (...args: Parameters<U>) => Promise<T>,
|
||||
>(
|
||||
fn: U,
|
||||
cache: Cache<Promise<T>>,
|
||||
): (key: unknown, ...args: Parameters<U>) => Promise<T> {
|
||||
return async (key, ...args) => {
|
||||
if (cache.has(key)) {
|
||||
return (await cache.get(key)) as T;
|
||||
}
|
||||
|
||||
const value = fn(...args);
|
||||
cache.set(key, value);
|
||||
|
||||
return await value;
|
||||
};
|
||||
}
|
||||
|
||||
export function memoize<T, U>(fn: (arg: U) => T): [(arg: U) => T, Cache<T>] {
|
||||
const cache = new Map<unknown, T>();
|
||||
const callback = withCache(fn, cache);
|
||||
|
||||
Reference in New Issue
Block a user